katana-cli [WIP] #79
katana-cli [WIP] #79
Conversation
| @@ -45,7 +45,7 @@ spec: | |||
| containers: | |||
| - name: create-data-dirs | |||
| image: busybox | |||
| command: ["sh", "-c", "mkdir /mnt/gogs /mnt/mysql /mnt/mongo /mnt/kashira /mnt/kissaki && sleep infinity"] | |||
| command: ["sh", "-c", "rm -rf /mnt/gogs /mnt/mysql /mnt/mongo /mnt/kashira /mnt/kissaki && mkdir /mnt/gogs /mnt/mysql /mnt/mongo /mnt/kashira /mnt/kissaki && sleep infinity"] | |||
There was a problem hiding this comment.
why do you need to delete dirs in container? Is it cause it picking it up from volumes, but that won't be required while setup as new volume would be created ?
There was a problem hiding this comment.
I discussed it with paradox he said that sometimes it get stuck in loop of a function because of pre-existing directories
so he asked to add this code for first deleting the directories.
cmd/infraset.go
Outdated
|
|
||
| for _, m := range clusterConfig.TemplatedManifests { | ||
|
|
||
| manifest := &bytes.Buffer{} |
There was a problem hiding this comment.
try writing most of functions not directly in cmd func, use it to call the required details. so we can reuse them. Like here for applying , use the deployment.deploycluster if its compatible.
See imgpkg code for inspiration.
There was a problem hiding this comment.
okay will check it once again
No description provided.